Skip to content
Snippets Groups Projects
Verified Commit 513366d7 authored by Loïs Poujade's avatar Loïs Poujade
Browse files

Remove useless comment/TODO

babel.config.json:
comment was false, it was not a warning ignored when building
dependencies; but an option that babel expects to be at the same value
for these 3 plugins

cf this commit from mirador original repo : https://github.com/ProjectMirador/mirador/commit/c79d87885940c8c68447543ad6fb8b658a848dcc

AnnotationItem.js: cf issue #5
parent 2de71320
Branches
No related tags found
No related merge requests found
...@@ -47,7 +47,6 @@ module.exports = function (api) { ...@@ -47,7 +47,6 @@ module.exports = function (api) {
const plugins = [ const plugins = [
'babel-plugin-macros', 'babel-plugin-macros',
'@babel/plugin-transform-destructuring', '@babel/plugin-transform-destructuring',
// TODO loose: which options is ignored in depencies ?
['@babel/plugin-proposal-private-methods', { loose: true }], ['@babel/plugin-proposal-private-methods', { loose: true }],
['@babel/plugin-proposal-private-property-in-object', { loose: true }], ['@babel/plugin-proposal-private-property-in-object', { loose: true }],
['@babel/plugin-proposal-class-properties', { loose: true }], ['@babel/plugin-proposal-class-properties', { loose: true }],
......
...@@ -138,7 +138,6 @@ export default class AnnotationItem { ...@@ -138,7 +138,6 @@ export default class AnnotationItem {
break; break;
case 'object': case 'object':
temporalfragmentSelector = selector.find(s => s.type && s.type === 'FragmentSelector'); temporalfragmentSelector = selector.find(s => s.type && s.type === 'FragmentSelector');
// TODO regex for t=5,10 t=,10 t=5 ? cf w3c media fragments
match = temporalfragmentSelector && temporalfragmentSelector.value.match(/t=(.*?)(&|$)/); match = temporalfragmentSelector && temporalfragmentSelector.value.match(/t=(.*?)(&|$)/);
break; break;
default: default:
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment