From 513366d7a39a86c4b7e605bc148b9ca0d8c40ec9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Lo=C3=AFs=20Poujade?= <lois.poujade@tetras-libre.fr>
Date: Wed, 23 Nov 2022 09:58:04 +0100
Subject: [PATCH] Remove useless comment/TODO
babel.config.json:
comment was false, it was not a warning ignored when building
dependencies; but an option that babel expects to be at the same value
for these 3 plugins
cf this commit from mirador original repo : https://github.com/ProjectMirador/mirador/commit/c79d87885940c8c68447543ad6fb8b658a848dcc
AnnotationItem.js: cf issue #5
---
babel.config.js | 1 -
src/lib/AnnotationItem.js | 1 -
2 files changed, 2 deletions(-)
diff --git a/babel.config.js b/babel.config.js
index 982d91dfd..a03ed912e 100644
--- a/babel.config.js
+++ b/babel.config.js
@@ -47,7 +47,6 @@ module.exports = function (api) {
const plugins = [
'babel-plugin-macros',
'@babel/plugin-transform-destructuring',
- // TODO loose: which options is ignored in depencies ?
['@babel/plugin-proposal-private-methods', { loose: true }],
['@babel/plugin-proposal-private-property-in-object', { loose: true }],
['@babel/plugin-proposal-class-properties', { loose: true }],
diff --git a/src/lib/AnnotationItem.js b/src/lib/AnnotationItem.js
index 0d5fcae8d..d927ec071 100644
--- a/src/lib/AnnotationItem.js
+++ b/src/lib/AnnotationItem.js
@@ -138,7 +138,6 @@ export default class AnnotationItem {
break;
case 'object':
temporalfragmentSelector = selector.find(s => s.type && s.type === 'FragmentSelector');
- // TODO regex for t=5,10 t=,10 t=5 ? cf w3c media fragments
match = temporalfragmentSelector && temporalfragmentSelector.value.match(/t=(.*?)(&|$)/);
break;
default:
--
GitLab