Skip to content
Snippets Groups Projects
Commit f053db43 authored by Camille Simiand's avatar Camille Simiand
Browse files

Increase phpstan to level 4 and fix errors

parent 32629742
Branches
No related tags found
1 merge request!27tuleap-108-add-stricter-code-quality-tools-configuration
Pipeline #662 failed
parameters:
level: 3
level: 4
paths:
- tests/
symfony:
......
parameters:
level: 3
level: 4
paths:
- src/
symfony:
container_xml_path: var/cache/dev/App_KernelDevDebugContainer.xml
doctrine:
objectManagerLoader: tests/object-manager.php
\ No newline at end of file
......@@ -32,7 +32,7 @@ class Capsule
/**
*
* //@ORM\Column(name="aut_crea", type="string", length=255, nullable=false)
* @ORM\Column(name="aut_crea", type="int", length=255, nullable=false)
*
* @ORM\ManyToOne(targetEntity="App\Entity\User", inversedBy="capsulesCreated")
* @ORM\JoinColumn(name="aut_crea", referencedColumnName="id")
......@@ -48,7 +48,7 @@ class Capsule
/**
*
* //@ORM\Column(name="aut_maj", type="string", length=255, nullable=false)
* @ORM\Column(name="aut_maj", type="int", length=255)
*
* @ORM\ManyToOne(targetEntity="App\Entity\User", inversedBy="capsulesEdited")
* @ORM\JoinColumn(name="aut_maj", referencedColumnName="id")
......
......@@ -19,15 +19,15 @@ class ResetPasswordRequest implements ResetPasswordRequestInterface
* @ORM\GeneratedValue
* @ORM\Column(type="integer")
*/
private $id;
private int $id;
/**
* @ORM\ManyToOne(targetEntity=User::class)
* @ORM\JoinColumn(nullable=false)
*/
private $user;
private User $user;
public function __construct(object $user, \DateTimeInterface $expiresAt, string $selector, string $hashedToken)
public function __construct(User $user, \DateTimeInterface $expiresAt, string $selector, string $hashedToken)
{
$this->user = $user;
$this->initialize($expiresAt, $selector, $hashedToken);
......@@ -38,7 +38,7 @@ class ResetPasswordRequest implements ResetPasswordRequestInterface
return $this->id;
}
public function getUser(): object
public function getUser(): User
{
return $this->user;
}
......
......@@ -59,6 +59,7 @@ class ProjectControllerTest extends WebTestCase
$this->object_manager->flush();
}
/** @phpstan-ignore-next-line */
private function getDOMDocument(): \DOMDocument
{
$dom_xml = new \DOMDocument();
......@@ -90,7 +91,7 @@ class ProjectControllerTest extends WebTestCase
self::assertInstanceOf(Capsule::class, $capsule_in_db);
$capsule_name_in_db = $capsule_in_db->getName();
$dom_xml = self::getDomDocument();
$dom_xml = $this->getDomDocument();
$video_node = $dom_xml->getElementsByTagName('video')->item(0);
$video_url_in_xml_file = $video_node->getAttribute('url');
......
......@@ -148,7 +148,7 @@ class RegistrationControllerTest extends WebTestCase
$this->assertResponseIsSuccessful('/register_mail_sent');
}
private function registerUser(string $userEmail, KernelBrowser &$client): ?Crawler
private function registerUser(string $userEmail, KernelBrowser &$client): Crawler
{
$crawler = $client->request('GET', '/register');
......
<?php
use App\Kernel;
use Symfony\Component\Dotenv\Dotenv;
require __DIR__ . '/../vendor/autoload.php';
(new Dotenv())->bootEnv(__DIR__ . '/../.env');
$kernel = new Kernel($_SERVER['APP_ENV'], (bool) $_SERVER['APP_DEBUG']);
$kernel->boot();
return $kernel->getContainer()->get('doctrine')->getManager();
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment