Skip to content
Snippets Groups Projects
Commit 4f837fc4 authored by Camille Simiand's avatar Camille Simiand
Browse files

Fix phpstan errors level 1

Remove ContratHelper requires within withAttribute() methods
parent 0c034f0a
No related branches found
No related tags found
1 merge request!27tuleap-108-add-stricter-code-quality-tools-configuration
This commit is part of merge request !27. Comments created here will be created in the context of that merge request.
......@@ -23,10 +23,6 @@ class CapsuleBuilder
public function withName(string $name): CapsuleBuilder
{
ContractHelper::requires(
isset($name) && '' !== trim($name),
"The capsule should have a valid name (current: '{$name}')"
);
$this->capsule->setName($name);
$this->hasRequiredName = true;
return $this;
......@@ -34,10 +30,6 @@ class CapsuleBuilder
public function withCreationAuthor(User $creation_author): CapsuleBuilder
{
ContractHelper::requires(
isset($creation_author),
"The capsule should have a valid creation author"
);
$this->capsule->setCreationAuthor($creation_author);
$this->hasRequiredCreationAuthor = true;
return $this;
......@@ -45,10 +37,6 @@ class CapsuleBuilder
public function withCreationDate(\DateTime $creation_date): CapsuleBuilder
{
ContractHelper::requires(
isset($creation_date),
"The capsule should have a valid date time"
);
$this->capsule->setCreationDate($creation_date);
$this->hastRequiredCreationDate = true;
return $this;
......@@ -57,10 +45,6 @@ class CapsuleBuilder
public function withPreviewLink(string $preview_link): CapsuleBuilder
{
ContractHelper::requires(
isset($preview_link) && '' !== trim($preview_link),
"The capsule should have a valid preview link (current: '{$preview_link}')"
);
$this->capsule->setPreviewLink($preview_link);
$this->hasRequiredPreviewLink = true;
return $this;
......@@ -68,10 +52,6 @@ class CapsuleBuilder
public function withEditionLink(string $edition_link): CapsuleBuilder
{
ContractHelper::requires(
isset($edition_link),
"The capsule should have a valid edition link (current: '{$edition_link}')"
);
$this->capsule->setEditionLink($edition_link);
$this->hasRequiredEditionLink = true;
return $this;
......@@ -85,10 +65,6 @@ class CapsuleBuilder
public function withUpdateDate(\DateTime $update_date): CapsuleBuilder
{
ContractHelper::requires(
isset($update_date),
"The capsule should have a valid update date)"
);
$this->capsule->setUpdatedDate($update_date);
$this->hasRequiredUpdateDate = true;
return $this;
......
......@@ -26,10 +26,6 @@ class UserBuilder
public function withEmail(string $email): UserBuilder
{
ContractHelper::requires(
isset($email) && '' !== trim($email),
"The user should have a valid email (current: '{$email}')"
);
$this->user->setEmail($email);
$this->hasRequiredEmail = true;
return $this;
......@@ -37,10 +33,6 @@ class UserBuilder
public function withFirstName(string $firstName): UserBuilder
{
ContractHelper::requires(
isset($firstName) && '' !== trim($firstName),
"The user should have a valid firstname (current: '{$firstName}')"
);
$this->user->setFirstName($firstName);
$this->hasRequiredFirstName = true;
return $this;
......@@ -48,10 +40,6 @@ class UserBuilder
public function withLastName(string $lastName): UserBuilder
{
ContractHelper::requires(
isset($lastName) && '' !== trim($lastName),
"The user should have a valid lastname (current: '{$lastName}')"
);
$this->user->setLastName($lastName);
$this->hasRequiredLastName = true;
return $this;
......@@ -59,10 +47,6 @@ class UserBuilder
public function withSalt(string $salt): UserBuilder
{
ContractHelper::requires(
isset($salt),
"The user should have a valid salt (current: '{$salt}')"
);
$this->user->setSalt($salt);
$this->hasRequiredSalt = true;
return $this;
......@@ -70,10 +54,6 @@ class UserBuilder
public function withPassword(string $password): UserBuilder
{
ContractHelper::requires(
isset($password) && '' !== trim($password),
"The user should have a valid password (current: '{$password}')"
);
$this->user->setPassword($this->password_hasher->hashPassword($this->user, $password));
$this->hasRequiredPassword = true;
return $this;
......@@ -81,11 +61,6 @@ class UserBuilder
public function withRoles(array $roles): UserBuilder
{
ContractHelper::requires(
isset($roles),
"The user should have a valid roles"
);
if (! in_array(['ROLE_USER'], $roles)) {
$roles[] = 'ROLE_USER';
}
......@@ -97,10 +72,6 @@ class UserBuilder
public function withIsVerified(bool $is_verified): UserBuilder
{
ContractHelper::requires(
isset($is_verified),
"The user should have a valid is_verified (current: '{$is_verified}')"
);
$this->user->setIsVerified($is_verified);
$this->hasRequiredIsVerified = true;
return $this;
......
......@@ -2,9 +2,8 @@
namespace App\Helper;
use _PHPStan_c862bb974\Nette\Neon\Exception;
use App\Curl\CurlHandle;
use phpDocumentor\Reflection\Types\Boolean;
use Exception;
use Symfony\Component\HttpFoundation\BinaryFileResponse;
use Symfony\Component\HttpFoundation\File\Exception\FileException;
use Symfony\Component\HttpFoundation\File\Exception\FileNotFoundException;
......
<?php
use App\Kernel;
use Symfony\Component\Dotenv\Dotenv;
require dirname(__DIR__) . '/vendor/autoload.php';
(new Dotenv())->bootEnv(dirname(__DIR__) . '/../.env');
$kernel = new Kernel($_SERVER['APP_ENV'], (bool) $_SERVER['APP_DEBUG']);
$kernel->boot();
return $kernel->getContainer()->get('doctrine')->getManager();
\ No newline at end of file
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment