Skip to content
Snippets Groups Projects
Unverified Commit eefc88a3 authored by Chris Beer's avatar Chris Beer Committed by GitHub
Browse files

Pluralize item counts for English, at least; fixes #3268 (#3446)

parent d215c3da
No related branches found
No related tags found
No related merge requests found
...@@ -135,7 +135,7 @@ export class ManifestListItem extends React.Component { ...@@ -135,7 +135,7 @@ export class ManifestListItem extends React.Component {
</Grid> </Grid>
<Grid item xs={8} sm={4}> <Grid item xs={8} sm={4}>
<Typography className={ns('manifest-list-item-provider')}>{provider || t('addedFromUrl')}</Typography> <Typography className={ns('manifest-list-item-provider')}>{provider || t('addedFromUrl')}</Typography>
<Typography>{t('numItems', { number: size })}</Typography> <Typography>{t('numItems', { count: size, number: size })}</Typography>
</Grid> </Grid>
<Grid item xs={4} sm={2}> <Grid item xs={4} sm={2}>
......
...@@ -26,7 +26,7 @@ export class WindowSideBarAnnotationsPanel extends Component { ...@@ -26,7 +26,7 @@ export class WindowSideBarAnnotationsPanel extends Component {
titleControls={<AnnotationSettings windowId={windowId} />} titleControls={<AnnotationSettings windowId={windowId} />}
> >
<div className={classes.section}> <div className={classes.section}>
<Typography component="p" variant="subtitle2">{t('showingNumAnnotations', { number: annotationCount })}</Typography> <Typography component="p" variant="subtitle2">{t('showingNumAnnotations', { count: annotationCount, number: annotationCount })}</Typography>
</div> </div>
{canvasIds.map((canvasId, index) => ( {canvasIds.map((canvasId, index) => (
......
...@@ -93,7 +93,8 @@ ...@@ -93,7 +93,8 @@
"moveCompanionWindowToRight": "Move to right", "moveCompanionWindowToRight": "Move to right",
"nextCanvas": "Next item", "nextCanvas": "Next item",
"noItemSelected": "No item selected", "noItemSelected": "No item selected",
"numItems": "{{number}} items", "numItems": "{{number}} item",
"numItems_plural": "{{number}} items",
"off": "Off", "off": "Off",
"openCompanionWindow_annotations": "Annotations", "openCompanionWindow_annotations": "Annotations",
"openCompanionWindow_attribution": "Rights", "openCompanionWindow_attribution": "Rights",
...@@ -121,7 +122,8 @@ ...@@ -121,7 +122,8 @@
"searchSubmitAria": "Submit search", "searchSubmitAria": "Submit search",
"searchTitle": "Search", "searchTitle": "Search",
"selectWorkspaceMenu": "Select workspace type", "selectWorkspaceMenu": "Select workspace type",
"showingNumAnnotations": "Showing {{number}} annotations", "showingNumAnnotations": "Showing {{number}} annotation",
"showingNumAnnotations_plural": "Showing {{number}} annotations",
"showCollection": "Show collection", "showCollection": "Show collection",
"showZoomControls": "Show zoom controls", "showZoomControls": "Show zoom controls",
"sidebarPanelsNavigation": "Sidebar panels navigation", "sidebarPanelsNavigation": "Sidebar panels navigation",
...@@ -134,8 +136,10 @@ ...@@ -134,8 +136,10 @@
"thumbnailNavigation": "Thumbnails", "thumbnailNavigation": "Thumbnails",
"thumbnails": "Thumbnails", "thumbnails": "Thumbnails",
"toggleWindowSideBar": "Toggle sidebar", "toggleWindowSideBar": "Toggle sidebar",
"totalCollections": "{{count}} collections", "totalCollections": "{{count}} collection",
"totalManifests": "{{count}} manifests", "totalCollections_plural": "{{count}} collections",
"totalManifests": "{{count}} manifest",
"totalManifests_plural": "{{count}} manifests",
"tryAgain": "Try again", "tryAgain": "Try again",
"untitled": "[Untitled]", "untitled": "[Untitled]",
"view": "View", "view": "View",
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment