Update json-server startup/shutdown to prevent rouge processes

jest-puppeteer.config.js

@@ -2,8 +2,11 @@ module.exports = {
   launch: {
     headless: process.env.HEADLESS !== 'false',
   },
-  server: {
+  server: [{
     command: 'npm run server -- -p 4488',
     port: 4488,
   },
+  {
+    command: 'npm run server:json',
+  }],
 };

package.json

@@ -6,15 +6,13 @@
   "scripts": {
     "lint": "node_modules/.bin/eslint ./ && node_modules/.bin/sass-lint -v ./src/styles/**/*",
     "server": "node_modules/.bin/http-server",
-    "pretest": "npm run server:json",
-    "posttest": "node ./scripts/json-server/kill-server.js",
     "test": "npm run build && npm run lint && jest -c jest.json --coverage",
     "test:watch": "jest -c jest.json --watch",
     "build": "webpack --mode=production",
     "build:dev": "webpack --mode=development",
     "build:watch": "webpack --watch --mode=development",
     "start": "npm run build:dev && concurrently \"npm run build:watch\" \"npm run server -- -p 4444\"",
-    "server:json": "node ./scripts/json-server/server.js >> ./scripts/json-server/json-server.log 2>&1 </dev/null &"
+    "server:json": "node ./scripts/json-server/server.js >> ./scripts/json-server/json-server.log"
   },
   "license": "Apache-2.0",
   "contributors": [

scripts/json-server/kill-server.js

-const os = process.platform;
-const execute = require('child_process').exec;
-
-if (os === 'darwin') {
-  console.log('darwin not supported');
-} else if (os === 'win32') {
-  console.log('windows not supported');
-} else {
-  execute('pkill -f server.js', (error, stdout, stderr) => {
-    console.log(`${stdout}`);
-    console.log(`${stderr}`);
-    if (error !== null) {
-      console.log(`exec error: ${error}`);
-    }
-  });
-}