Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
M
mirador-video-annotations
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package registry
Container registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
GitLab community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Loïs Poujade
mirador-video-annotations
Commits
07ecde4a
Unverified
Commit
07ecde4a
authored
Apr 8, 2021
by
Jack Reed
Committed by
GitHub
Apr 8, 2021
Browse files
Options
Downloads
Patches
Plain Diff
Enhance configuration settings so that a window can specify the sidebarPanel (#3357)
parent
cb5905e5
No related branches found
No related tags found
No related merge requests found
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
__tests__/src/actions/window.test.js
+25
-0
25 additions, 0 deletions
__tests__/src/actions/window.test.js
src/state/actions/window.js
+7
-3
7 additions, 3 deletions
src/state/actions/window.js
with
32 additions
and
3 deletions
__tests__/src/actions/window.test.js
+
25
−
0
View file @
07ecde4a
...
...
@@ -152,6 +152,31 @@ describe('window actions', () => {
expect
(
action
.
companionWindows
[
0
]).
toMatchObject
({
content
:
'
thumbnailNavigation
'
});
});
it
(
'
enables a window to override the panel being displayed
'
,
()
=>
{
const
options
=
{
id
:
'
helloworld
'
,
sideBarPanel
:
'
canvas
'
,
};
const
mockState
=
{
companionWindows
:
{},
config
:
{
thumbnailNavigation
:
{},
window
:
{
defaultSideBarPanel
:
'
info
'
,
},
},
workspace
:
{},
};
const
mockDispatch
=
jest
.
fn
(()
=>
({}));
const
mockGetState
=
jest
.
fn
(()
=>
mockState
);
const
thunk
=
actions
.
addWindow
(
options
);
thunk
(
mockDispatch
,
mockGetState
);
const
action
=
mockDispatch
.
mock
.
calls
[
0
][
0
];
expect
(
action
.
window
.
sideBarPanel
).
toEqual
(
'
canvas
'
);
});
it
(
'
pulls a provided manifest out
'
,
()
=>
{
const
options
=
{
canvasIndex
:
1
,
...
...
This diff is collapsed.
Click to expand it.
src/state/actions/window.js
+
7
−
3
View file @
07ecde4a
...
...
@@ -44,10 +44,12 @@ export function addWindow({ companionWindows, manifest, ...options }) {
),
];
if
(
config
.
window
.
defaultSideBarPanel
||
config
.
window
.
sideBarPanel
)
{
if
(
options
.
sideBarPanel
||
config
.
window
.
defaultSideBarPanel
||
config
.
window
.
sideBarPanel
)
{
defaultCompanionWindows
.
unshift
(
{
content
:
config
.
window
.
defaultSideBarPanel
||
config
.
window
.
sideBarPanel
,
content
:
options
.
sideBarPanel
||
config
.
window
.
defaultSideBarPanel
||
config
.
window
.
sideBarPanel
,
default
:
true
,
id
:
`cw-
${
uuid
()}
`
,
position
:
'
left
'
,
...
...
@@ -72,7 +74,9 @@ export function addWindow({ companionWindows, manifest, ...options }) {
sideBarOpen
:
config
.
window
.
sideBarOpenByDefault
!==
undefined
?
config
.
window
.
sideBarOpenByDefault
:
config
.
window
.
sideBarOpen
,
sideBarPanel
:
config
.
window
.
defaultSideBarPanel
||
config
.
window
.
sideBarPanel
,
sideBarPanel
:
options
.
sideBarPanel
||
config
.
window
.
defaultSideBarPanel
||
config
.
window
.
sideBarPanel
,
thumbnailNavigationId
:
cwThumbs
,
};
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment