Skip to content
Snippets Groups Projects
Select Git revision
  • 4d7b50e6eb17ae19283bd1e543ac0435953cb1b1
  • annotation-on-video default protected
  • demo_ci
  • 3-upstream-01022023
  • master
  • gh3538-captions
  • 16-adapt-for-images-annot
  • 15-api-for-annotations-on-video
  • 15-annotations-on-videos
  • video_for_annotations
  • wip-1-annotations-on-videos
  • 9-videoviewer-tests
  • 9_wip_videotests
  • 6-fix-tests-and-ci
  • _fix_ci
  • wip-webpack-from-git
16 results

CONTRIBUTING.md

Blame
  • user avatar
    aeschylus authored and GitHub committed
    43e1c7ad
    History
    After you've reviewed these contribution guidelines, you'll be all set to contribute to this project.
    CONTRIBUTING.md 2.75 KiB

    This document serves as a reference for the Mirador community and others interested in the project. It aims to outline agreed upon practices that are used in the development and maintenance of the Mirador software.

    Contributing to Mirador

    Contributions to Mirador are always welcome, however, it will always be helpful to begin any large change by submitting an issue or engaging with the Mirador community. For more on this, see plugin architecture. Mirador 3.0 and beyond adheres to semantic versioning so that adopters and contributors can better understand what changes can be expected in released versions of the software.

    All contributions should be submitted as a GitHub pull request to the master branch. Pull requests must be reviewed and accepted by another Mirador maintainer and pass all continuous integration checks. Contributions should have tests for the feature or bug fix, documentation and should conform to the Mirador agreed upon coding style. Contributions should not include a “built” version of Mirador, this will help in reducing merge conflicts.

    Adding dependencies

    Careful consideration should be given when adding software dependencies to Mirador. During the code review process, new dependencies may be evaluated on the following considerations:

    • added size of the dependency
    • whether or not that dependency is maintained and tested
    • how the dependency may interact with Mirador embedded in other environments

    As a general rule, any dependencies added should not be committed directly, but should use a package manager to require the dependency.

    Dependencies should also be scoped (both for style and script) so that they do not interact with a containing application.

    Coding style