-
- Downloads
Remove RootRef and fix scrolling entire page
Fixes some underlying inconsistencies with scrolling behavior including: - Making sure that the ScrollTo component is the child - Removing RootRef which is removed from Material-UI and deprecated in React.StrictMode - While scrollIntoView is awesome, it scrolls the entire page even when in an iframe which can cause unexpected jumping. Fixes #3302
Showing
- __tests__/integration/mirador/iframe.html 15 additions, 0 deletions__tests__/integration/mirador/iframe.html
- __tests__/src/components/ScrollTo.test.js 20 additions, 17 deletions__tests__/src/components/ScrollTo.test.js
- __tests__/src/components/SidebarIndexTableOfContents.test.js 24 additions, 26 deletions__tests__/src/components/SidebarIndexTableOfContents.test.js
- src/components/CompanionWindow.js 4 additions, 1 deletionsrc/components/CompanionWindow.js
- src/components/ScrollTo.js 21 additions, 8 deletionssrc/components/ScrollTo.js
- src/components/SearchPanel.js 39 additions, 41 deletionssrc/components/SearchPanel.js
- src/components/SidebarIndexList.js 15 additions, 15 deletionssrc/components/SidebarIndexList.js
- src/components/SidebarIndexTableOfContents.js 29 additions, 29 deletionssrc/components/SidebarIndexTableOfContents.js
- src/components/WindowSideBarCanvasPanel.js 62 additions, 63 deletionssrc/components/WindowSideBarCanvasPanel.js
- src/containers/CompanionWindow.js 2 additions, 0 deletionssrc/containers/CompanionWindow.js
- src/extend/withRef.js 9 additions, 0 deletionssrc/extend/withRef.js
Loading
Please register or sign in to comment