Merge pull request #3402 from ProjectMirador/3401-expext-annotations-without-selectors

Fix #3401 - expect annotations without target selector

__tests__/src/extend/withPlugins.test.js

@@ -126,6 +126,7 @@ describe('PluginHoc: if wrap plugins AND add plugins exist for target', () => {
   });
   it('renders the first wrap plugin, renders add plugins if plugin/props are passed through', () => {
     /** */ const WrapPluginComponentA = plugin => (
+      // eslint-disable-next-line react/destructuring-assignment
       <plugin.TargetComponent {...plugin.targetProps} {...plugin} />
     );
     /** */ const WrapPluginComponentB = props => <div>look i am a plugin</div>;

__tests__/src/lib/CanvasAnnotationDisplay.test.js

@@ -34,7 +34,7 @@ describe('CanvasAnnotationDisplay', () => {
       expect(subject.svgContext).toHaveBeenCalled();
       expect(subject.fragmentContext).not.toHaveBeenCalled();
     });
-    it('selects fragmentSelector if no svg present', () => {
+    it('selects fragmentSelector if present and if no svg is present', () => {
       const context = {
         stroke: jest.fn(),
       };
@@ -47,6 +47,19 @@ describe('CanvasAnnotationDisplay', () => {
       expect(subject.svgContext).not.toHaveBeenCalled();
       expect(subject.fragmentContext).toHaveBeenCalled();
     });
+    it('ignores annotations without selectors', () => {
+      const context = {
+        stroke: jest.fn(),
+      };
+      const subject = createSubject({
+        resource: new AnnotationResource({ on: 'www.example.com' }),
+      });
+      subject.svgContext = jest.fn();
+      subject.fragmentContext = jest.fn();
+      subject.toContext(context);
+      expect(subject.svgContext).not.toHaveBeenCalled();
+      expect(subject.fragmentContext).not.toHaveBeenCalled();
+    });
   });
   describe('svgString', () => {
     it('selects the svg selector string value', () => {

src/lib/CanvasAnnotationDisplay.js

@@ -20,7 +20,7 @@ export default class CanvasAnnotationDisplay {
     this.context = context;
     if (this.resource.svgSelector) {
       this.svgContext();
-    } else {
+    } else if (this.resource.fragmentSelector) {
       this.fragmentContext();
     }
   }