Skip to content
Snippets Groups Projects
Unverified Commit 6bb39c87 authored by Chris Beer's avatar Chris Beer Committed by GitHub
Browse files

Merge pull request #1803 from ProjectMirador/1783-canvas-index-config

Allow canvasIndex to be passed in with the window config on viewer…
parents a0fb8755 c6929cff
No related branches found
No related tags found
No related merge requests found
...@@ -14,6 +14,7 @@ ...@@ -14,6 +14,7 @@
id: 'mirador', id: 'mirador',
windows: [{ windows: [{
loadedManifest: 'https://iiif.harvardartmuseums.org/manifests/object/299843', loadedManifest: 'https://iiif.harvardartmuseums.org/manifests/object/299843',
canvasIndex: 2,
}, },
{ {
loadedManifest: 'https://media.nga.gov/public/manifests/nga_highlights.json', loadedManifest: 'https://media.nga.gov/public/manifests/nga_highlights.json',
......
...@@ -10,8 +10,10 @@ describe('Thumbnail navigation', () => { ...@@ -10,8 +10,10 @@ describe('Thumbnail navigation', () => {
let windows = await page.evaluate(() => ( let windows = await page.evaluate(() => (
miradorInstance.store.getState().windows miradorInstance.store.getState().windows
)); ));
expect(Object.values(windows)[0].canvasIndex).toBe(0); expect(Object.values(windows)[0].canvasIndex).toBe(2); // test harness in index.html starts at 2
await page.waitFor(1000);
await expect(page).toClick('.mirador-thumbnail-nav-canvas-1'); await expect(page).toClick('.mirador-thumbnail-nav-canvas-1');
await expect(page).toMatchElement('.mirador-thumbnail-nav-canvas-1.mirador-current-canvas', { timeout: 1500 });
windows = await page.evaluate(() => ( windows = await page.evaluate(() => (
miradorInstance.store.getState().windows miradorInstance.store.getState().windows
)); ));
......
...@@ -46,6 +46,7 @@ describe('MiradorViewer', () => { ...@@ -46,6 +46,7 @@ describe('MiradorViewer', () => {
id: 'mirador', id: 'mirador',
windows: [{ windows: [{
loadedManifest: 'https://iiif.harvardartmuseums.org/manifests/object/299843', loadedManifest: 'https://iiif.harvardartmuseums.org/manifests/object/299843',
canvasIndex: 2,
}, },
{ {
loadedManifest: 'https://iiif.harvardartmuseums.org/manifests/object/299843', loadedManifest: 'https://iiif.harvardartmuseums.org/manifests/object/299843',
...@@ -57,6 +58,8 @@ describe('MiradorViewer', () => { ...@@ -57,6 +58,8 @@ describe('MiradorViewer', () => {
const { windows } = instance.store.getState(); const { windows } = instance.store.getState();
const windowIds = Object.keys(windows); const windowIds = Object.keys(windows);
expect(Object.keys(windowIds).length).toBe(2); expect(Object.keys(windowIds).length).toBe(2);
expect(windows[windowIds[0]].canvasIndex).toBe(2);
expect(windows[windowIds[1]].canvasIndex).toBe(0);
expect(windows[windowIds[0]].thumbnailNavigationPosition).toBe('bottom'); expect(windows[windowIds[0]].thumbnailNavigationPosition).toBe('bottom');
expect(windows[windowIds[1]].thumbnailNavigationPosition).toBe('off'); expect(windows[windowIds[1]].thumbnailNavigationPosition).toBe('off');
}); });
......
...@@ -51,6 +51,7 @@ class MiradorViewer { ...@@ -51,6 +51,7 @@ class MiradorViewer {
} }
store.dispatch(actions.fetchManifest(miradorWindow.loadedManifest)); store.dispatch(actions.fetchManifest(miradorWindow.loadedManifest));
store.dispatch(actions.addWindow({ store.dispatch(actions.addWindow({
canvasIndex: (miradorWindow.canvasIndex || 0),
manifestId: miradorWindow.loadedManifest, manifestId: miradorWindow.loadedManifest,
thumbnailNavigationPosition, thumbnailNavigationPosition,
})); }));
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment