Skip to content
Snippets Groups Projects
Commit fbff6815 authored by Camille Simiand's avatar Camille Simiand
Browse files

Refacto

parent 098bedd2
Branches
Tags
1 merge request!45tuleap-81-allow-a-new-user-to-access-the-capsule-edition-mode
......@@ -61,7 +61,8 @@ class CapsuleEditorController extends AbstractController
}
$current_capsule_editors_users = $capsule->getEditors()->toArray();
if (! in_array($current_user, $current_capsule_editors_users)) {
if (! $capsule->getEditors()->contains($current_user)) {
// in_array($current_user, $current_capsule_editors_users)) {
$this->addFlash(
'warning',
$this->translator->trans(
......
......@@ -3,7 +3,6 @@
namespace App\DataFixtures;
use App\Builder\CapsuleBuilder;
use App\Entity\CapsuleEditor;
use App\Entity\User;
use DateTime;
use Doctrine\Bundle\FixturesBundle\Fixture;
......@@ -67,11 +66,6 @@ class CapsuleFixtures extends Fixture implements DependentFixtureInterface
}
);
// $editor = new CapsuleEditor();
// $editor->setCapsuleId(1);
// $editor->setUserId(3);
// $manager->persist($editor);
$manager->flush();
}
......
......@@ -66,16 +66,10 @@ class UserRepository extends ServiceEntityRepository implements PasswordUpgrader
*/
public function getUsersFromIds(array $user_ids): array
{
$users = [];
foreach ($user_ids as $user_id) {
$user = $this->findOneBy(['id' => $user_id]);
if (null === $user) {
throw new Exception('User was not found');
}
$users[] = $user;
}
return $users;
return $this->createQueryBuilder('u')
->andWhere('u.id in (:ids)')
->setParameter('ids', $user_ids)
->getQuery()
->getResult();
}
}
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment