From abc1984ad38b8d853229187b1e55ce91e0f1a053 Mon Sep 17 00:00:00 2001
From: Camille Simiand <camille.simiand@tetras-libre.fr>
Date: Fri, 7 Jan 2022 09:22:27 +0100
Subject: [PATCH] Fix phpstan level 3 errors

---
 tests/functional/ProjectControllerTest.php      | 16 ++++++++--------
 tests/functional/RegistrationControllerTest.php |  2 +-
 2 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/tests/functional/ProjectControllerTest.php b/tests/functional/ProjectControllerTest.php
index 1da59ed..cb02496 100644
--- a/tests/functional/ProjectControllerTest.php
+++ b/tests/functional/ProjectControllerTest.php
@@ -4,7 +4,7 @@ namespace App\Tests\functional;
 
 use App\Entity\Capsule;
 use App\Entity\User;
-use Doctrine\ORM\EntityManager;
+use Doctrine\Persistence\ObjectManager;
 use Symfony\Bundle\FrameworkBundle\KernelBrowser;
 use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
 use Symfony\Component\DomCrawler\Form;
@@ -13,7 +13,7 @@ use Symfony\Component\Filesystem\Filesystem;
 class ProjectControllerTest extends WebTestCase
 {
     private KernelBrowser $client;
-    private EntityManager $entity_manager;
+    private ObjectManager $object_manager;
     private Form $form;
     private const TEST_DIR_PATH = __DIR__ . '/../../legacy/';
     private const CAPSULE_NAME = 'TestCapsuleName';
@@ -27,11 +27,11 @@ class ProjectControllerTest extends WebTestCase
         self::ensureKernelShutdown();
         $this->client = static::createClient();
 
-        $this->entity_manager = $this->client->getContainer()
+        $this->object_manager = $this->client->getContainer()
             ->get('doctrine')
             ->getManager();
 
-        $verified_user = $this->entity_manager
+        $verified_user = $this->object_manager
             ->getRepository(User::class)
             ->findOneBy(['email' => 'defaultUser@localhost.com'])
         ;
@@ -53,10 +53,10 @@ class ProjectControllerTest extends WebTestCase
         $file_system = new Filesystem();
         $file_system->remove(self::TEST_DIR_PATH . self::CAPSULE_NAME);
 
-        $capsule_repository = $this->entity_manager->getRepository(Capsule::class);
+        $capsule_repository = $this->object_manager->getRepository(Capsule::class);
         $last_capsule = $capsule_repository->findOneBy(['name' => self::CAPSULE_NAME]);
-        $this->entity_manager->remove($last_capsule);
-        $this->entity_manager->flush();
+        $this->object_manager->remove($last_capsule);
+        $this->object_manager->flush();
     }
 
     private function getDOMDocument(): \DOMDocument
@@ -84,7 +84,7 @@ class ProjectControllerTest extends WebTestCase
 
         $this->client->followRedirect();
 
-        $capsule_repository = $this->entity_manager->getRepository(Capsule::class);
+        $capsule_repository = $this->object_manager->getRepository(Capsule::class);
         $capsule_in_db = $capsule_repository->findOneBy(['name' => self::CAPSULE_NAME]);
 
         self::assertInstanceOf(Capsule::class, $capsule_in_db);
diff --git a/tests/functional/RegistrationControllerTest.php b/tests/functional/RegistrationControllerTest.php
index 9377322..acba987 100644
--- a/tests/functional/RegistrationControllerTest.php
+++ b/tests/functional/RegistrationControllerTest.php
@@ -164,7 +164,7 @@ class RegistrationControllerTest extends WebTestCase
         $form['registration_form[email]'] = $userEmail;
         $form['registration_form[plainPassword][first]'] = 'password';
         $form['registration_form[plainPassword][second]'] = 'password';
-        $form['registration_form[agreeTerms]'] = 1;
+        $form['registration_form[agreeTerms]'] = "1";
 
         return $client->submit($form);
     }
-- 
GitLab