From 4f992eceb7dc1e13e7a460def0744b9503ef6c1d Mon Sep 17 00:00:00 2001
From: Jack Reed <phillipjreed@gmail.com>
Date: Tue, 27 Oct 2020 10:33:03 -0600
Subject: [PATCH] id is not a used prop on MenuItem
---
__tests__/integration/mirador/sequence_switching.test.js | 4 ++--
src/components/WindowSideBarCanvasPanel.js | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/__tests__/integration/mirador/sequence_switching.test.js b/__tests__/integration/mirador/sequence_switching.test.js
index 404e8dc27..1fdb850bc 100644
--- a/__tests__/integration/mirador/sequence_switching.test.js
+++ b/__tests__/integration/mirador/sequence_switching.test.js
@@ -28,8 +28,8 @@ describe('Window Sidebar Sequence Dropdown', () => {
await expect(page).toMatchElement(`#${windowId} button[aria-label="Index"]`);
await expect(page).toClick(`#${windowId} button[aria-label="Index"]`);
await expect(page).toClick('#mui-component-select-sequenceId');
- await expect(page).toMatchElement('#sequence-1');
- await expect(page).toClick('#sequence-1');
+ await expect(page).toMatchElement('[data-value="https://www.e-codices.unifr.ch/metadata/iiif/gau-Fragment/sequence/Sequence-1741.json"]');
+ await expect(page).toClick('[data-value="https://www.e-codices.unifr.ch/metadata/iiif/gau-Fragment/sequence/Sequence-1741.json"]');
await expect(page).toMatchElement('p', { text: 'fragm1a_1r' });
});
});
diff --git a/src/components/WindowSideBarCanvasPanel.js b/src/components/WindowSideBarCanvasPanel.js
index 98cac15a2..b327a3db9 100644
--- a/src/components/WindowSideBarCanvasPanel.js
+++ b/src/components/WindowSideBarCanvasPanel.js
@@ -119,7 +119,7 @@ export class WindowSideBarCanvasPanel extends Component {
classes={{ select: classes.select }}
className={classes.selectEmpty}
>
- { sequences.map((s, i) => <MenuItem id={`sequence-${i}`} value={s.id} key={s.id}><Typography variant="body2">{ WindowSideBarCanvasPanel.getUseableLabel(s, i) }</Typography></MenuItem>) }
+ { sequences.map((s, i) => <MenuItem value={s.id} key={s.id}><Typography variant="body2">{ WindowSideBarCanvasPanel.getUseableLabel(s, i) }</Typography></MenuItem>) }
</Select>
</FormControl>
)
--
GitLab