From b3480250852ab3b1e9eb00bd7df0480e797d619a Mon Sep 17 00:00:00 2001
From: Stefan Weil <sw@weilnetz.de>
Date: Sun, 28 Oct 2018 22:59:35 +0100
Subject: [PATCH] Add some missing variable declarations
This fixes some errors reported by LGTM.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
js/lib/isfahan.js | 1 +
js/src/annotations/osd-region-draw-tool.js | 2 +-
js/src/utils/saveController.js | 4 ++--
js/src/viewer/manifestListItem.js | 2 +-
js/src/widgets/searchTab.js | 2 +-
5 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/js/lib/isfahan.js b/js/lib/isfahan.js
index b3f7d1fb5..0ea81c7a2 100644
--- a/js/lib/isfahan.js
+++ b/js/lib/isfahan.js
@@ -45,6 +45,7 @@ var Isfahan = function(configObject) {
n = group.length,
x = rect.x,
y = rect.y,
+ d,
o;
var offset = 0;
while (++i < n) {
diff --git a/js/src/annotations/osd-region-draw-tool.js b/js/src/annotations/osd-region-draw-tool.js
index ac7e01305..4c19af40a 100644
--- a/js/src/annotations/osd-region-draw-tool.js
+++ b/js/src/annotations/osd-region-draw-tool.js
@@ -137,7 +137,7 @@
if (typeof annotation === 'object' && annotation.on) {
for (var i = 0; i < strategies.length; i++) {
if (strategies[i].isThisType(annotation)) {
- shapeArray = strategies[i].parseRegion(annotation, this);
+ var shapeArray = strategies[i].parseRegion(annotation, this);
return shapeArray;
}
}
diff --git a/js/src/utils/saveController.js b/js/src/utils/saveController.js
index 395df1161..16a39204e 100755
--- a/js/src/utils/saveController.js
+++ b/js/src/utils/saveController.js
@@ -87,8 +87,8 @@
return false;
}
- saveModule = config.jsonStorageEndpoint.module,
- saveOptions = config.jsonStorageEndpoint.options;
+ var saveModule = config.jsonStorageEndpoint.module;
+ var saveOptions = config.jsonStorageEndpoint.options;
_this.storageModule = new $[saveModule](saveOptions);
var sessionID = window.location.hash.substring(1); // will return empty string if none exists, causing the or statement below to evaluate to false, generating a new sesssionID.
diff --git a/js/src/viewer/manifestListItem.js b/js/src/viewer/manifestListItem.js
index 793fa19b8..f55c7391d 100644
--- a/js/src/viewer/manifestListItem.js
+++ b/js/src/viewer/manifestListItem.js
@@ -108,7 +108,7 @@
var aspectRatio = canvas.height/canvas.width,
width = (_this.thumbHeight/aspectRatio);
- url = _this.manifest.getThumbnailForCanvas(canvas, width);
+ var url = _this.manifest.getThumbnailForCanvas(canvas, width);
_this.allImages.push({
url: url,
diff --git a/js/src/widgets/searchTab.js b/js/src/widgets/searchTab.js
index 71698d919..362cdea98 100644
--- a/js/src/widgets/searchTab.js
+++ b/js/src/widgets/searchTab.js
@@ -137,7 +137,7 @@
};
});
- templateData = {
+ var templateData = {
searchService: searchServiceIdArray
};
--
GitLab