From 6c8aee892cdf4276e1345fcdde608232d050e83e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lo=C3=AFs=20Poujade?= <lois.poujade@tetras-libre.fr> Date: Tue, 29 Nov 2022 12:25:33 +0100 Subject: [PATCH] MaterialUI auto upgrade ran `npx @mui/codemod v5.0.0/link-underline-hover` --- .../src/components/AttributionPanel.test.js | 4 +-- .../components/ManifestRelatedLinks.test.js | 14 ++++----- src/components/AttributionPanel.js | 2 +- src/components/CollectionDialog.js | 2 +- src/components/ManifestRelatedLinks.js | 30 +++++++++++++++---- 5 files changed, 36 insertions(+), 16 deletions(-) diff --git a/__tests__/src/components/AttributionPanel.test.js b/__tests__/src/components/AttributionPanel.test.js index dc3d8ad1c..b70b14883 100644 --- a/__tests__/src/components/AttributionPanel.test.js +++ b/__tests__/src/components/AttributionPanel.test.js @@ -39,14 +39,14 @@ describe('AttributionPanel', () => { expect( wrapper.find(Typography).at(1).matchesElement( <Typography> - <Link href="http://example.com">http://example.com</Link> + <Link href="http://example.com" underline="hover">http://example.com</Link> </Typography>, ), ).toBe(true); expect( wrapper.find(Typography).at(2).matchesElement( <Typography> - <Link href="http://stanford.edu">http://stanford.edu</Link> + <Link href="http://stanford.edu" underline="hover">http://stanford.edu</Link> </Typography>, ), ).toBe(true); diff --git a/__tests__/src/components/ManifestRelatedLinks.test.js b/__tests__/src/components/ManifestRelatedLinks.test.js index 9653d2d02..d36eff62b 100644 --- a/__tests__/src/components/ManifestRelatedLinks.test.js +++ b/__tests__/src/components/ManifestRelatedLinks.test.js @@ -68,7 +68,7 @@ describe('ManifestRelatedLinks', () => { expect( wrapper.find(Typography).at(2) .matchesElement( - <Typography component="dd"><Link href="http://example.com/">Home page</Link></Typography>, + <Typography component="dd"><Link href="http://example.com/" underline="hover">Home page</Link></Typography>, ), ).toBe(true); }); @@ -85,7 +85,7 @@ describe('ManifestRelatedLinks', () => { wrapper.find(Typography).at(4) .matchesElement( <Typography component="dd"> - <Link href="http://example.com/pdf">PDF Version</Link> + <Link href="http://example.com/pdf" underline="hover">PDF Version</Link> </Typography>, ), ).toBe(true); @@ -102,7 +102,7 @@ describe('ManifestRelatedLinks', () => { expect( wrapper.find(Typography).at(6) .matchesElement( - <Typography component="dd"><Link href="http://example.com/related">http://example.com/related</Link></Typography>, + <Typography component="dd"><Link href="http://example.com/related" underline="hover">http://example.com/related</Link></Typography>, ), ).toBe(true); @@ -110,7 +110,7 @@ describe('ManifestRelatedLinks', () => { wrapper.find(Typography).at(7) .matchesElement( <Typography component="dd"> - <Link href="http://example.com/video">Video</Link> + <Link href="http://example.com/video" underline="hover">Video</Link> <Typography>(video/ogg)</Typography> </Typography>, ), @@ -129,7 +129,7 @@ describe('ManifestRelatedLinks', () => { wrapper.find(Typography).at(10) .matchesElement( <Typography component="dd"> - <Link href="http://example.com/a">A</Link> + <Link href="http://example.com/a" underline="hover">A</Link> <Typography>(text/html)</Typography> </Typography>, ), @@ -138,7 +138,7 @@ describe('ManifestRelatedLinks', () => { expect( wrapper.find(Typography).at(12) .matchesElement( - <Typography component="dd"><Link href="http://example.com/b">http://example.com/b</Link></Typography>, + <Typography component="dd"><Link href="http://example.com/b" underline="hover">http://example.com/b</Link></Typography>, ), ).toBe(true); }); @@ -154,7 +154,7 @@ describe('ManifestRelatedLinks', () => { expect( wrapper.find(Typography).at(14) .matchesElement( - <Typography component="dd"><Link href="http://example.com/">http://example.com/</Link></Typography>, + <Typography component="dd"><Link href="http://example.com/" underline="hover">http://example.com/</Link></Typography>, ), ).toBe(true); }); diff --git a/src/components/AttributionPanel.js b/src/components/AttributionPanel.js index a984d1d66..5e7b90075 100644 --- a/src/components/AttributionPanel.js +++ b/src/components/AttributionPanel.js @@ -45,7 +45,7 @@ export class AttributionPanel extends Component { <Typography variant="subtitle2" component="dt">{t('rights')}</Typography> { rights.map(v => ( <Typography variant="body1" component="dd" key={v.toString()}> - <Link target="_blank" rel="noopener noreferrer" href={v}> + <Link target="_blank" rel="noopener noreferrer" href={v} underline="hover"> {v} </Link> </Typography> diff --git a/src/components/CollectionDialog.js b/src/components/CollectionDialog.js index d344440b9..2f478e1ad 100644 --- a/src/components/CollectionDialog.js +++ b/src/components/CollectionDialog.js @@ -212,7 +212,7 @@ export class CollectionDialog extends Component { <Typography variant="subtitle2" component="dt">{t('rights')}</Typography> { rights.map(v => ( <Typography variant="body1" component="dd" key={v}> - <Link target="_blank" rel="noopener noreferrer" href={v}> + <Link target="_blank" rel="noopener noreferrer" href={v} underline="hover"> {v} </Link> </Typography> diff --git a/src/components/ManifestRelatedLinks.js b/src/components/ManifestRelatedLinks.js index 231a8cc27..dae777362 100644 --- a/src/components/ManifestRelatedLinks.js +++ b/src/components/ManifestRelatedLinks.js @@ -47,7 +47,11 @@ export class ManifestRelatedLinks extends Component { { homepage.map(page => ( <Typography key={page.value} variant="body1" component="dd"> - <Link target="_blank" rel="noopener noreferrer" href={page.value}> + <Link + target="_blank" + rel="noopener noreferrer" + href={page.value} + underline="hover"> {page.label || page.value} </Link> </Typography> @@ -61,7 +65,11 @@ export class ManifestRelatedLinks extends Component { { renderings.map(rendering => ( <Typography key={rendering.value} variant="body1" component="dd"> - <Link target="_blank" rel="noopener noreferrer" href={rendering.value}> + <Link + target="_blank" + rel="noopener noreferrer" + href={rendering.value} + underline="hover"> {rendering.label || rendering.value} </Link> </Typography> @@ -75,7 +83,11 @@ export class ManifestRelatedLinks extends Component { { related.map(relatedItem => ( <Typography key={relatedItem.value} variant="body1" component="dd"> - <Link target="_blank" rel="noopener noreferrer" href={relatedItem.value}> + <Link + target="_blank" + rel="noopener noreferrer" + href={relatedItem.value} + underline="hover"> {relatedItem.label || relatedItem.value} </Link> { relatedItem.format && ( @@ -92,7 +104,11 @@ export class ManifestRelatedLinks extends Component { { seeAlso.map(seeAlsoItem => ( <Typography key={seeAlsoItem.value} variant="body1" component="dd"> - <Link target="_blank" rel="noopener noreferrer" href={seeAlsoItem.value}> + <Link + target="_blank" + rel="noopener noreferrer" + href={seeAlsoItem.value} + underline="hover"> {seeAlsoItem.label || seeAlsoItem.value} </Link> { seeAlsoItem.format && ( @@ -107,7 +123,11 @@ export class ManifestRelatedLinks extends Component { <> <Typography variant="subtitle2" component="dt">{t('iiif_manifest')}</Typography> <Typography variant="body1" component="dd"> - <Link target="_blank" rel="noopener noreferrer" href={manifestUrl}> + <Link + target="_blank" + rel="noopener noreferrer" + href={manifestUrl} + underline="hover"> {manifestUrl} </Link> </Typography> -- GitLab